chore: add ESLint configuration for api and web packages
Some checks failed
CI / test (push) Failing after 43s

- Introduced ESLint configuration files for both api and web packages to enforce coding standards.
- Updated MinioService and TokenService to improve error handling and type definitions.
- Refactored localStorage access in web components to use window.localStorage for consistency.
- Enhanced ESLint rules in base configuration to improve code quality and maintainability.
This commit is contained in:
Juan Sebastián Montoya 2025-05-06 01:16:16 -05:00
parent a1590e7228
commit 857ffcd6b4
14 changed files with 46 additions and 38 deletions

View file

@ -91,7 +91,7 @@ export class MinioService {
try { try {
await this.client.statObject(this.bucketName, objectName); await this.client.statObject(this.bucketName, objectName);
return true; return true;
} catch (error) { } catch (_error) {
return false; return false;
} }
} }

View file

@ -90,7 +90,7 @@ export class TokenService {
); );
const tx = txn const tx = txn
? (callback: Function) => callback(txn) ? (callback: (tx: TransactionClient) => Promise<void>) => callback(txn)
: this.prisma.$transaction.bind(this.prisma); : this.prisma.$transaction.bind(this.prisma);
await tx(async (tx) => { await tx(async (tx) => {

View file

@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/no-unsafe-function-type */
import { MercuriusContext } from 'mercurius'; import { MercuriusContext } from 'mercurius';
const isCallback = ( const isCallback = (

View file

@ -2,7 +2,6 @@
"name": "web", "name": "web",
"private": true, "private": true,
"version": "0.0.0", "version": "0.0.0",
"type": "module",
"scripts": { "scripts": {
"lint": "eslint . --max-warnings 0", "lint": "eslint . --max-warnings 0",
"check-types": "tsc --noEmit", "check-types": "tsc --noEmit",

View file

@ -27,8 +27,8 @@ function App() {
// Check if user is already authenticated // Check if user is already authenticated
const checkAuth = () => { const checkAuth = () => {
const token = localStorage.getItem('token'); const token = window.localStorage.getItem('token');
const storedUserId = localStorage.getItem('userId'); const storedUserId = window.localStorage.getItem('userId');
if (token && storedUserId) { if (token && storedUserId) {
setIsAuthenticated(true); setIsAuthenticated(true);
@ -52,8 +52,8 @@ function App() {
} catch (error) { } catch (error) {
console.error('Logout failed:', error); console.error('Logout failed:', error);
} finally { } finally {
localStorage.removeItem('token'); window.localStorage.removeItem('token');
localStorage.removeItem('userId'); window.localStorage.removeItem('userId');
setIsAuthenticated(false); setIsAuthenticated(false);
setUserId(''); setUserId('');
setSelectedRoomId(null); setSelectedRoomId(null);

View file

@ -75,10 +75,7 @@ interface ChatRoomProps {
} }
export function ChatRoom(props: ChatRoomProps) { export function ChatRoom(props: ChatRoomProps) {
const [variables, setVariables] = createSignal({ const [variables, setVariables] = createSignal({});
id: props.roomId,
roomId: props.roomId,
});
const [message, setMessage] = createSignal(''); const [message, setMessage] = createSignal('');
const [messages, setMessages] = createSignal<Message[]>([]); const [messages, setMessages] = createSignal<Message[]>([]);
const [confirmLeave, setConfirmLeave] = createSignal(false); const [confirmLeave, setConfirmLeave] = createSignal(false);
@ -240,9 +237,9 @@ export function ChatRoom(props: ChatRoomProps) {
} }
}; };
document.addEventListener('mousedown', handleClickOutside); window.document.addEventListener('mousedown', handleClickOutside);
return () => { return () => {
document.removeEventListener('mousedown', handleClickOutside); window.document.removeEventListener('mousedown', handleClickOutside);
}; };
}); });
@ -345,8 +342,8 @@ export function ChatRoom(props: ChatRoomProps) {
{showEmojiPicker() && ( {showEmojiPicker() && (
<div ref={emojiPickerContainer} class='emoji-picker-container'> <div ref={emojiPickerContainer} class='emoji-picker-container'>
{/* @ts-ignore */} {/* @ts-expect-error - emoji-picker-element is not typed */}
<emoji-picker ref={(el: Picker) => setPickerRef(el)}></emoji-picker> <emoji-picker ref={(el: Picker) => setPickerRef(el)} />
</div> </div>
)} )}
</form> </form>

View file

@ -48,8 +48,8 @@ export function LoginForm(props: LoginFormProps) {
if (result.data?.login) { if (result.data?.login) {
const { accessToken, user } = result.data.login; const { accessToken, user } = result.data.login;
localStorage.setItem('token', accessToken); window.localStorage.setItem('token', accessToken);
localStorage.setItem('userId', user.id); window.localStorage.setItem('userId', user.id);
props.onLoginSuccess(accessToken, user.id); props.onLoginSuccess(accessToken, user.id);
} else { } else {
setError('Login failed: No data received from server'); setError('Login failed: No data received from server');

View file

@ -56,8 +56,8 @@ export function RegisterForm(props: RegisterFormProps) {
if (result.data?.register) { if (result.data?.register) {
const { accessToken, user } = result.data.register; const { accessToken, user } = result.data.register;
localStorage.setItem('token', accessToken); window.localStorage.setItem('token', accessToken);
localStorage.setItem('userId', user.id); window.localStorage.setItem('userId', user.id);
props.onRegisterSuccess(accessToken, user.id); props.onRegisterSuccess(accessToken, user.id);
} else { } else {
setError('Registration failed: No data received from server'); setError('Registration failed: No data received from server');

View file

@ -172,7 +172,7 @@ export function RoomList(props: RoomListProps) {
// Check if the current user is a member of a room // Check if the current user is a member of a room
const isMember = (room: Room) => { const isMember = (room: Room) => {
const userId = localStorage.getItem('userId'); const userId = window.localStorage.getItem('userId');
return room.members?.some((member) => member.id === userId); return room.members?.some((member) => member.id === userId);
}; };

View file

@ -37,7 +37,7 @@ export const client = createClient({
], ],
// For development, we'll add a simple header-based authentication // For development, we'll add a simple header-based authentication
fetchOptions: () => { fetchOptions: () => {
const token = localStorage.getItem('token'); const token = window.localStorage.getItem('token');
return { return {
credentials: 'include', credentials: 'include',
headers: { headers: {

View file

@ -1,4 +1,4 @@
import js from '@eslint/js'; import eslint from '@eslint/js';
import turboPlugin from 'eslint-plugin-turbo'; import turboPlugin from 'eslint-plugin-turbo';
import tseslint from 'typescript-eslint'; import tseslint from 'typescript-eslint';
@ -7,18 +7,30 @@ import tseslint from 'typescript-eslint';
* *
* @type {import("eslint").Linter.Config[]} * @type {import("eslint").Linter.Config[]}
* */ * */
export const config = [ export const config = tseslint.config(
js.configs.recommended, eslint.configs.recommended,
...tseslint.configs.recommended, tseslint.configs.recommended,
[
{ {
plugins: { plugins: {
turbo: turboPlugin, turbo: turboPlugin,
}, },
rules: { rules: {
'turbo/no-undeclared-env-vars': 'warn', 'turbo/no-undeclared-env-vars': 'warn',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-empty-object-type': 'off',
'@typescript-eslint/no-unused-vars': [
'error',
{
argsIgnorePattern: '^_',
varsIgnorePattern: '^_',
caughtErrorsIgnorePattern: '^_',
},
],
}, },
}, },
{ {
ignores: ['dist/**'], ignores: ['dist/**'],
}, },
]; ]
);

View file

@ -1,4 +1,3 @@
import js from '@eslint/js';
import solid from 'eslint-plugin-solid/configs/typescript'; import solid from 'eslint-plugin-solid/configs/typescript';
import * as tsParser from '@typescript-eslint/parser'; import * as tsParser from '@typescript-eslint/parser';
import { config as baseConfig } from './base.js'; import { config as baseConfig } from './base.js';
@ -9,11 +8,10 @@ import { config as baseConfig } from './base.js';
* @type {import("eslint").Linter.Config[]} */ * @type {import("eslint").Linter.Config[]} */
export const config = [ export const config = [
...baseConfig, ...baseConfig,
js.configs.recommended,
{ {
files: ['**/*.{ts,tsx}'], files: ['**/*.{ts,tsx}'],
...solid, ...solid,
ignores: ['turbo/generators/**'], ignores: ['turbo/generators/**', 'vite.config.ts'],
languageOptions: { languageOptions: {
parser: tsParser, parser: tsParser,
parserOptions: { parserOptions: {
@ -21,6 +19,7 @@ export const config = [
}, },
globals: { globals: {
window: true, window: true,
console: true,
}, },
}, },
}, },